Document experimental csv module #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiade
added
the
Area: OSS Content
There was a problem hiding this comment.
Thanks for the docs updates @oleiade! 🙇
I left some comments, mostly small edits related to the style guide or for consistency. One thing that I think would be nice to do as well is to add the module to the docs/sources/next/shared/javascript-api/k6-experimental.md file as well, so this module shows up in the main JavaScript API page. I didn't want to push directly to your PR, but let me know if you'd like me to make this change. :)
docs/sources/next/javascript-api/k6-experimental/csv/Options.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
heitortsergent
approved these changes
Sep 23, 2024
Co-authored-by: Heitor Tashiro Sergent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This Pull Request adds documentation for the new experimental csv module.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/nextfolder of the documentation.Related PR(s)/Issue(s)
k6/#3743